44r0n7/privacy.sexy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Increase testability through dependency injection

Browse Source 
- Remove existing integration tests for hooks as they're redundant after
  this change.
- Document the pattern in relevant documentation.
- Introduce `useEnvironment` to increase testability.
- Update components to inject dependencies rather than importing hooks
  directly.
This commit is contained in:
undergroundwires
2023-08-15 18:11:30 +02:00
parent 39e650cf11
commit ae75059cc1
32 changed files with 209 additions and 201 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
tests/integration/presentation/components/Shared/Hooks/UseApplication.spec.ts
View File

@@ -1,29 +0,0 @@
import 'mocha';
import { expect } from 'chai';
import { useApplication } from '@/presentation/components/Shared/Hooks/UseApplication';
import { ApplicationFactory } from '@/application/ApplicationFactory';
describe('UseApplication', () => {
it('should return the actual application from factory', async () => {
// arrange
const expected = await ApplicationFactory.Current.getApp();
// act
const { application } = useApplication(expected);
// assert
expect(application).to.equal(expected);
});
it('should return the actual info from the application', async () => {
// arrange
const app = await ApplicationFactory.Current.getApp();
const expected = app.info;
// act
const { info } = useApplication();
// assert
expect(info).to.equal(expected);
});
});

83
tests/integration/presentation/components/Shared/Hooks/UseCollectionState.spec.ts
View File

@@ -1,83 +0,0 @@
import 'mocha';
import { expect } from 'chai';
import { useCollectionState } from '@/presentation/components/Shared/Hooks/UseCollectionState';
import { IReadOnlyApplicationContext } from '@/application/Context/IApplicationContext';
describe('UseCollectionState', () => {
describe('currentContext', () => {
it('multiple calls get the same instance', () => {
// act
const firstContext = useCollectionState().currentContext;
const secondContext = useCollectionState().currentContext;
// assert
expect(firstContext).to.equal(secondContext);
});
});
describe('currentState', () => {
it('returns current collection state', () => {
// arrange
const { currentContext } = useCollectionState();
const expectedState = currentContext.state;
// act
const { currentState } = useCollectionState();
const actualState = currentState.value;
// assert
expect(expectedState).to.equal(actualState);
});
it('returns changed collection state', () => {
// arrange
const { currentContext, currentState, modifyCurrentContext } = useCollectionState();
const newOs = pickNonCurrentOs(currentContext);
// act
modifyCurrentContext((context) => {
context.changeContext(newOs);
});
const expectedState = currentContext.state;
// assert
expect(currentState.value).to.equal(expectedState);
});
});
describe('modifyCurrentContext', () => {
it('modifies the current context', () => {
// arrange
const { currentContext, currentState, modifyCurrentContext } = useCollectionState();
const expectedOs = pickNonCurrentOs(currentContext);
// act
modifyCurrentContext((context) => {
context.changeContext(expectedOs);
});
// assert
expect(currentContext.state.os).to.equal(expectedOs);
expect(currentState.value.os).to.equal(expectedOs);
});
});
describe('modifyCurrentState', () => {
it('modifies the current state', () => {
// arrange
const { currentState, modifyCurrentState } = useCollectionState();
const expectedFilter = 'expected-filter';
// act
modifyCurrentState((state) => {
state.filter.setFilter(expectedFilter);
});
// assert
const actualFilter = currentState.value.filter.currentFilter.query;
expect(actualFilter).to.equal(expectedFilter);
});
});
});
function pickNonCurrentOs(context: IReadOnlyApplicationContext) {
return context.app.getSupportedOsList().find((os) => os !== context.state.os);
}