Refactor to enforce strictNullChecks
This commit applies `strictNullChecks` to the entire codebase to improve maintainability and type safety. Key changes include: - Remove some explicit null-checks where unnecessary. - Add necessary null-checks. - Refactor static factory functions for a more functional approach. - Improve some test names and contexts for better debugging. - Add unit tests for any additional logic introduced. - Refactor `createPositionFromRegexFullMatch` to its own function as the logic is reused. - Prefer `find` prefix on functions that may return `undefined` and `get` prefix for those that always return a value.
This commit is contained in:
@@ -1,7 +1,7 @@
|
||||
import { describe, it, expect } from 'vitest';
|
||||
import { EventSubscriptionCollection } from '@/infrastructure/Events/EventSubscriptionCollection';
|
||||
import { EventSubscriptionStub } from '@tests/unit/shared/Stubs/EventSubscriptionStub';
|
||||
import { itEachAbsentCollectionValue, itEachAbsentObjectValue } from '@tests/unit/shared/TestCases/AbsentTests';
|
||||
import { itEachAbsentCollectionValue } from '@tests/unit/shared/TestCases/AbsentTests';
|
||||
import { IEventSubscription } from '@/infrastructure/Events/IEventSource';
|
||||
|
||||
describe('EventSubscriptionCollection', () => {
|
||||
@@ -140,7 +140,7 @@ function describeSubscriptionValidations(
|
||||
handleValue: (subscriptions: IEventSubscription[]) => void,
|
||||
) {
|
||||
describe('throws error if no subscriptions are provided', () => {
|
||||
itEachAbsentCollectionValue((absentValue) => {
|
||||
itEachAbsentCollectionValue<IEventSubscription>((absentValue) => {
|
||||
// arrange
|
||||
const expectedError = 'missing subscriptions';
|
||||
|
||||
@@ -149,24 +149,6 @@ function describeSubscriptionValidations(
|
||||
|
||||
// assert
|
||||
expect(act).to.throw(expectedError);
|
||||
});
|
||||
});
|
||||
|
||||
describe('throws error if nullish subscriptions are provided', () => {
|
||||
itEachAbsentObjectValue((absentValue) => {
|
||||
// arrange
|
||||
const expectedError = 'missing subscription in list';
|
||||
const subscriptions = [
|
||||
new EventSubscriptionStub(),
|
||||
absentValue,
|
||||
new EventSubscriptionStub(),
|
||||
];
|
||||
|
||||
// act
|
||||
const act = () => handleValue(subscriptions);
|
||||
|
||||
// assert
|
||||
expect(act).to.throw(expectedError);
|
||||
});
|
||||
}, { excludeUndefined: true, excludeNull: true });
|
||||
});
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user