Refactor to enforce strictNullChecks

This commit applies `strictNullChecks` to the entire codebase to improve
maintainability and type safety. Key changes include:

- Remove some explicit null-checks where unnecessary.
- Add necessary null-checks.
- Refactor static factory functions for a more functional approach.
- Improve some test names and contexts for better debugging.
- Add unit tests for any additional logic introduced.
- Refactor `createPositionFromRegexFullMatch` to its own function as the
  logic is reused.
- Prefer `find` prefix on functions that may return `undefined` and
  `get` prefix for those that always return a value.
This commit is contained in:
undergroundwires
2023-11-12 22:54:00 +01:00
parent 7ab16ecccb
commit 949fac1a7c
294 changed files with 2477 additions and 2738 deletions

View File

@@ -1,5 +1,6 @@
import { describe, it, expect } from 'vitest';
import { Version } from '@/domain/Version';
import { itEachAbsentStringValue } from '../shared/TestCases/AbsentTests';
describe('Version', () => {
describe('invalid versions', () => {
@@ -19,20 +20,15 @@ describe('Version', () => {
}
});
describe('throws with empty string', () => {
// arrange
const expectedError = 'empty version';
const testCases = [
{ name: 'empty', value: '' },
{ name: 'undefined', value: undefined },
];
for (const testCase of testCases) {
it(`given ${testCase.name}`, () => {
// act
const act = () => new Version(testCase.value);
//
expect(act).to.throw(expectedError);
});
}
itEachAbsentStringValue((absentValue) => {
// arrange
const expectedError = 'empty version';
const value = absentValue;
// act
const act = () => new Version(value);
//
expect(act).to.throw(expectedError);
}, { excludeNull: true, excludeUndefined: true });
});
});
describe('valid versions', () => {