Refactor to enforce strictNullChecks

This commit applies `strictNullChecks` to the entire codebase to improve
maintainability and type safety. Key changes include:

- Remove some explicit null-checks where unnecessary.
- Add necessary null-checks.
- Refactor static factory functions for a more functional approach.
- Improve some test names and contexts for better debugging.
- Add unit tests for any additional logic introduced.
- Refactor `createPositionFromRegexFullMatch` to its own function as the
  logic is reused.
- Prefer `find` prefix on functions that may return `undefined` and
  `get` prefix for those that always return a value.
This commit is contained in:
undergroundwires
2023-11-12 22:54:00 +01:00
parent 7ab16ecccb
commit 949fac1a7c
294 changed files with 2477 additions and 2738 deletions

View File

@@ -36,8 +36,15 @@ describe('Enum', () => {
describe('throws as expected', () => {
// arrange
const enumName = 'ParsableEnum';
const testCases = [
...getAbsentStringTestCases().map((test) => ({
const testScenarios: ReadonlyArray<{
readonly name: string;
readonly value: string;
readonly expectedError: string;
}> = [
...getAbsentStringTestCases({
excludeNull: true,
excludeUndefined: true,
}).map((test) => ({
name: test.valueName,
value: test.absentValue,
expectedError: `missing ${enumName}`,
@@ -59,7 +66,7 @@ describe('Enum', () => {
},
];
// act
for (const testCase of testCases) {
for (const testCase of testScenarios) {
it(testCase.name, () => {
const parser = createEnumParser(ParsableEnum);
const act = () => parser.parseEnum(testCase.value, enumName);
@@ -100,7 +107,6 @@ describe('Enum', () => {
// assert
new EnumRangeTestRunner(act)
.testOutOfRangeThrows()
.testAbsentValueThrows()
.testValidValueDoesNotThrow(validValue);
});
});