Refactor to enforce strictNullChecks
This commit applies `strictNullChecks` to the entire codebase to improve maintainability and type safety. Key changes include: - Remove some explicit null-checks where unnecessary. - Add necessary null-checks. - Refactor static factory functions for a more functional approach. - Improve some test names and contexts for better debugging. - Add unit tests for any additional logic introduced. - Refactor `createPositionFromRegexFullMatch` to its own function as the logic is reused. - Prefer `find` prefix on functions that may return `undefined` and `get` prefix for those that always return a value.
This commit is contained in:
@@ -28,7 +28,11 @@ function generateTestOptions(): ISanityCheckOptions[] {
|
||||
return generateBooleanPermutations(defaultOptions);
|
||||
}
|
||||
|
||||
function generateBooleanPermutations<T>(object: T): T[] {
|
||||
function generateBooleanPermutations<T>(object: T | undefined): T[] {
|
||||
if (!object) {
|
||||
return [];
|
||||
}
|
||||
|
||||
const keys = Object.keys(object) as (keyof T)[];
|
||||
|
||||
if (keys.length === 0) {
|
||||
@@ -47,7 +51,7 @@ function generateBooleanPermutations<T>(object: T): T[] {
|
||||
|
||||
const remainingKeys = Object.fromEntries(
|
||||
keys.slice(1).map((key) => [key, object[key]]),
|
||||
) as unknown as T;
|
||||
) as unknown as T | undefined;
|
||||
|
||||
const subPermutations = generateBooleanPermutations(remainingKeys);
|
||||
|
||||
|
||||
@@ -4,9 +4,6 @@ import { ISanityValidator } from '@/infrastructure/RuntimeSanity/Common/ISanityV
|
||||
export function itNoErrorsOnCurrentEnvironment(
|
||||
factory: () => ISanityValidator,
|
||||
) {
|
||||
if (!factory) {
|
||||
throw new Error('missing factory');
|
||||
}
|
||||
it('it does report errors on current environment', () => {
|
||||
// arrange
|
||||
const validator = factory();
|
||||
|
||||
@@ -23,7 +23,7 @@ function checkAllowedType(value: unknown) {
|
||||
if (Array.isArray(value)) {
|
||||
return value.every(checkAllowedType);
|
||||
}
|
||||
if (type === 'object' && value !== null) {
|
||||
if (type === 'object' && value !== null && value !== undefined) {
|
||||
return (
|
||||
// Every key should be a string
|
||||
Object.keys(value).every((key) => typeof key === 'string')
|
||||
|
||||
Reference in New Issue
Block a user