44r0n7/privacy.sexy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix broken npm installation and builds

Browse Source 
This commit fixes two issues:
a. Fix `npm install` not working
b. Fix building not working after npm install fix.

npm install fails with dependency resolution issue due to Vue CLI as
following:

```txt
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: cache-loader@4.1.0
...
```txt

As suggested in Vue issues regenerating packages-lock.json solves the
issue, see: vuejs/vue-cli#6793, vuejs/vue-cli#7095.

However with the new package-lock.json a Font Awesome dependency issue
breaks the builds such as the following:

```txt
ERROR in src/presentation/bootstrapping/Modules/IconBootstrapper.ts:17:7
TS2345: Argument of type 'IconDefinition' is not assignable to parameter of type 'IconDefinitionOrPack'.
  Type 'IconDefinition' is not assignable to type 'IconPack'.
    Index signature for type 'string' is missing in type 'IconDefinition'.
    15 |   public bootstrap(vue: VueConstructor): void {
    16 |     library.add(
  > 17 |       faGithub,
```

This is solved by adding a patch in `tsconfig.json`. This issue was
discussed in FortAwesome/Font-Awesome#12575 where the workaround was
recommended.
This commit is contained in:
undergroundwires
2022-09-22 20:13:20 +02:00
parent 8608072bfb
commit 924b326244
2 changed files with 7551 additions and 7615 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15139
package-lock.json generated
View File

File diff suppressed because it is too large Load Diff

3
tsconfig.json
View File

@@ -29,6 +29,9 @@
],
"@tests/*": [
"tests/*"
],
"@fortawesome/fontawesome-common-types": [
"./node_modules/@fortawesome/fontawesome-common-types/index"
]
}
},