Fix unresponsive copy button on instructions modal
This commit fixes the bug where the "Copy" button does not copy when
clicked on download instructions modal (on Linux and macOS).
This commit also introduces several improvements to the UI components
related to copy action and their interaction with the clipboard feature.
It adds more tests to avoid regression of the bugs and improves
maintainability, testability and adherence to Vue's reactive principles.
Changes include:
- Fix non-responsive copy button in the download instructions modal by
triggering a `click` event in `AppIcon.vue`.
- Improve `TheCodeButtons.vue`:
- Remove redundant `getCurrentCode` function.
- Separate components for each button for better separation of
concerns and higher testability.
- Use the `gap` property in the flexbox layout, replacing the less
explicit sibling combinator approach.
- Add `useClipboard` compositional hook for more idiomatic Vue approach
to interacting with the clipboard.
- Add `useCurrentCode` compositional hook to handle current code state
more effectively with unified logic.
- Abstract clipboard operations to an interface to isolate
responsibilities.
- Switch clipboard implementation to the `navigator.clipboard` API,
moving away from the deprecated `document.execCommand`.
- Move clipboard logic to the presentation layer to conform to
separation of concerns and domain-driven design principles.
- Improve `IconButton.vue` component to increase reusability with
consistent sizing.
This commit is contained in:
@@ -0,0 +1,67 @@
|
||||
import { describe, it, expect } from 'vitest';
|
||||
import { useClipboard } from '@/presentation/components/Shared/Hooks/Clipboard/UseClipboard';
|
||||
import { BrowserClipboard } from '@/presentation/components/Shared/Hooks/Clipboard/BrowserClipboard';
|
||||
import { ClipboardStub } from '@tests/unit/shared/Stubs/ClipboardStub';
|
||||
import { FunctionKeys } from '@/TypeHelpers';
|
||||
|
||||
describe('useClipboard', () => {
|
||||
it(`returns an instance of ${BrowserClipboard.name}`, () => {
|
||||
// arrange
|
||||
const expectedType = BrowserClipboard;
|
||||
// act
|
||||
const clipboard = useClipboard();
|
||||
// assert
|
||||
expect(clipboard).to.be.instanceOf(expectedType);
|
||||
});
|
||||
it('does not create a new instance if one is provided', () => {
|
||||
// arrange
|
||||
const expectedClipboard = new ClipboardStub();
|
||||
// act
|
||||
const actualClipboard = useClipboard(expectedClipboard);
|
||||
// assert
|
||||
expect(actualClipboard).to.equal(expectedClipboard);
|
||||
});
|
||||
describe('supports object destructuring', () => {
|
||||
type ClipboardFunction = FunctionKeys<ReturnType<typeof useClipboard>>;
|
||||
const testScenarios: {
|
||||
readonly [FunctionName in ClipboardFunction]:
|
||||
Parameters<ReturnType<typeof useClipboard>[FunctionName]>;
|
||||
} = {
|
||||
copyText: ['text-arg'],
|
||||
};
|
||||
Object.entries(testScenarios).forEach(([functionName, testFunctionArgs]) => {
|
||||
describe(functionName, () => {
|
||||
it('binds the method to the instance', () => {
|
||||
// arrange
|
||||
const expectedArgs = testFunctionArgs;
|
||||
const clipboardStub = new ClipboardStub();
|
||||
// act
|
||||
const clipboard = useClipboard(clipboardStub);
|
||||
const { [functionName as ClipboardFunction]: testFunction } = clipboard;
|
||||
// assert
|
||||
testFunction(...expectedArgs);
|
||||
const call = clipboardStub.callHistory.find((c) => c.methodName === functionName);
|
||||
expect(call).toBeDefined();
|
||||
expect(call.args).to.deep.equal(expectedArgs);
|
||||
});
|
||||
it('ensures method retains the clipboard instance context', () => {
|
||||
// arrange
|
||||
const clipboardStub = new ClipboardStub();
|
||||
const expectedThisContext = clipboardStub;
|
||||
let actualThisContext: typeof expectedThisContext | undefined;
|
||||
// eslint-disable-next-line func-names
|
||||
clipboardStub[functionName] = function () {
|
||||
// eslint-disable-next-line @typescript-eslint/no-this-alias
|
||||
actualThisContext = this;
|
||||
};
|
||||
// act
|
||||
const clipboard = useClipboard(clipboardStub);
|
||||
const { [functionName as ClipboardFunction]: testFunction } = clipboard;
|
||||
// assert
|
||||
testFunction(...testFunctionArgs);
|
||||
expect(expectedThisContext).to.equal(actualThisContext);
|
||||
});
|
||||
});
|
||||
});
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user