win: fix revert scripts for removing shortcuts

Revert scripts for removing shortcuts previously used hardcoded paths.
These paths are now replaced with system environment variables to allow
for broader configuration compatibility.
This commit is contained in:
undergroundwires
2024-06-11 12:06:46 +02:00
parent b29cd7b5f7
commit 8becc7dbc4

View File

@@ -19051,7 +19051,7 @@ actions:
- -
function: RemoveShortcutFiles function: RemoveShortcutFiles
parameters: parameters:
targetFile: C:\Users\undergroundwires\AppData\Local\Microsoft\OneDrive\OneDrive.exe targetFile: '%LOCALAPPDATA%\Microsoft\OneDrive\OneDrive.exe'
shortcutItems: |- shortcutItems: |-
@{ Revert = $True; Path = "$env:APPDATA\Microsoft\Windows\Start Menu\Programs\OneDrive.lnk"; } @{ Revert = $True; Path = "$env:APPDATA\Microsoft\Windows\Start Menu\Programs\OneDrive.lnk"; }
@{ Revert = $False; Path = "$env:USERPROFILE\Links\OneDrive.lnk"; } @{ Revert = $False; Path = "$env:USERPROFILE\Links\OneDrive.lnk"; }
@@ -19431,7 +19431,7 @@ actions:
# - `DisableEdgeDesktopShortcutCreation` because it's highly documented and it does not really bring value since this script already deletes `Microsoft Edge.lnk` from public folder. # - `DisableEdgeDesktopShortcutCreation` because it's highly documented and it does not really bring value since this script already deletes `Microsoft Edge.lnk` from public folder.
function: RemoveShortcutFiles function: RemoveShortcutFiles
parameters: parameters:
targetFile: C:\Program Files (x86)\Microsoft\Edge\Application\msedge.exe targetFile: '%PROGRAMFILES(X86)%\Microsoft\Edge\Application\msedge.exe'
shortcutItems: |- shortcutItems: |-
@{ Revert = $True; Path = "$env:ProgramData\Microsoft\Windows\Start Menu\Programs\Microsoft Edge.lnk"; } @{ Revert = $True; Path = "$env:ProgramData\Microsoft\Windows\Start Menu\Programs\Microsoft Edge.lnk"; }
@{ Revert = $True; Path = "$env:AppData\Microsoft\Internet Explorer\Quick Launch\Microsoft Edge.lnk"; } @{ Revert = $True; Path = "$env:AppData\Microsoft\Internet Explorer\Quick Launch\Microsoft Edge.lnk"; }
@@ -22656,12 +22656,13 @@ functions:
} }
} }
revertCode: |- revertCode: |-
$targetFile = "{{ $targetFile }}" $targetFilePath = "{{ $targetFile }}"
$expandedTargetFilePath = [System.Environment]::ExpandEnvironmentVariables($targetFilePath)
$shortcuts = @( $shortcuts = @(
{{ $shortcutItems }} {{ $shortcutItems }}
) )
if (-Not (Test-Path $targetFile)) { if (-Not (Test-Path $expandedTargetFilePath)) {
Write-Warning "Target file `"$targetFile`" does not exist." Write-Warning "Target file `"$expandedTargetFilePath`" does not exist."
} }
$wscriptShell = $null $wscriptShell = $null
try { try {
@@ -22680,7 +22681,7 @@ functions:
} }
try { try {
$shellShortcut = $wscriptShell.CreateShortcut($shortcut.Path) $shellShortcut = $wscriptShell.CreateShortcut($shortcut.Path)
$shellShortcut.TargetPath = $targetFile $shellShortcut.TargetPath = $expandedTargetFilePath
$shellShortcut.Save() $shellShortcut.Save()
Write-Output "Successfully created shortcut at `"$($shortcut.Path)`"." Write-Output "Successfully created shortcut at `"$($shortcut.Path)`"."
} catch { } catch {