Refactor code to comply with ESLint rules

Major refactoring using ESLint with rules from AirBnb and Vue.

Enable most of the ESLint rules and do necessary linting in the code.
Also add more information for rules that are disabled to describe what
they are and why they are disabled.

Allow logging (`console.log`) in test files, and in development mode
(e.g. when working with `npm run serve`), but disable it when
environment is production (as pre-configured by Vue). Also add flag
(`--mode production`) in `lint:eslint` command so production linting is
executed earlier in lifecycle.

Disable rules that requires a separate work. Such as ESLint rules that
are broken in TypeScript: no-useless-constructor (eslint/eslint#14118)
and no-shadow (eslint/eslint#13014).

src/application/Common/Array.ts

@@ -1,21 +1,21 @@
 // Compares to Array<T> objects for equality, ignoring order
 export function scrambledEqual<T>(array1: readonly T[], array2: readonly T[]) {
-    if (!array1) { throw new Error('undefined first array'); }
-    if (!array2) { throw new Error('undefined second array'); }
-    const sortedArray1 = sort(array1);
-    const sortedArray2 = sort(array2);
-    return sequenceEqual(sortedArray1, sortedArray2);
-    function sort(array: readonly T[]) {
-        return array.slice().sort();
-    }
+  if (!array1) { throw new Error('undefined first array'); }
+  if (!array2) { throw new Error('undefined second array'); }
+  const sortedArray1 = sort(array1);
+  const sortedArray2 = sort(array2);
+  return sequenceEqual(sortedArray1, sortedArray2);
+  function sort(array: readonly T[]) {
+    return array.slice().sort();
+  }
 }
 
 // Compares to Array<T> objects for equality in same order
 export function sequenceEqual<T>(array1: readonly T[], array2: readonly T[]) {
-    if (!array1) { throw new Error('undefined first array'); }
-    if (!array2) { throw new Error('undefined second array'); }
-    if (array1.length !== array2.length) {
-        return false;
-    }
-    return array1.every((val, index) => val === array2[index]);
+  if (!array1) { throw new Error('undefined first array'); }
+  if (!array2) { throw new Error('undefined second array'); }
+  if (array1.length !== array2.length) {
+    return false;
+  }
+  return array1.every((val, index) => val === array2[index]);
 }

src/application/Common/Enum.ts

@@ -1,54 +1,63 @@
 // Because we cannot do "T extends enum" 😞 https://github.com/microsoft/TypeScript/issues/30611
 export type EnumType = number | string;
-export type EnumVariable<T extends EnumType, TEnumValue extends EnumType> = { [key in T]: TEnumValue };
+export type EnumVariable<T extends EnumType, TEnumValue extends EnumType>
+  = { [key in T]: TEnumValue };
 
 export interface IEnumParser<TEnum> {
-    parseEnum(value: string, propertyName: string): TEnum;
-}
-export function createEnumParser<T extends EnumType, TEnumValue extends EnumType>(
-    enumVariable: EnumVariable<T, TEnumValue>): IEnumParser<TEnumValue> {
-    return {
-        parseEnum: (value, propertyName) => parseEnumValue(value, propertyName, enumVariable),
-    };
-}
-function parseEnumValue<T extends EnumType, TEnumValue extends EnumType>(
-    value: string,
-    enumName: string,
-    enumVariable: EnumVariable<T, TEnumValue>): TEnumValue {
-    if (!value) {
-        throw new Error(`undefined ${enumName}`);
-    }
-    if (typeof value !== 'string') {
-        throw new Error(`unexpected type of ${enumName}: "${typeof value}"`);
-    }
-    const casedValue = getEnumNames(enumVariable)
-        .find((enumValue) => enumValue.toLowerCase() === value.toLowerCase());
-    if (!casedValue) {
-        throw new Error(`unknown ${enumName}: "${value}"`);
-    }
-    return enumVariable[casedValue as keyof typeof enumVariable];
+  parseEnum(value: string, propertyName: string): TEnum;
 }
 
-export function getEnumNames<T extends EnumType, TEnumValue extends EnumType>(
-    enumVariable: EnumVariable<T, TEnumValue>): string[] {
-    return Object
-        .values(enumVariable)
-        .filter((enumMember) => typeof enumMember === 'string') as string[];
+export function createEnumParser<T extends EnumType, TEnumValue extends EnumType>(
+  enumVariable: EnumVariable<T, TEnumValue>,
+): IEnumParser<TEnumValue> {
+  return {
+    parseEnum: (value, propertyName) => parseEnumValue(value, propertyName, enumVariable),
+  };
+}
+
+function parseEnumValue<T extends EnumType, TEnumValue extends EnumType>(
+  value: string,
+  enumName: string,
+  enumVariable: EnumVariable<T, TEnumValue>,
+): TEnumValue {
+  if (!value) {
+    throw new Error(`undefined ${enumName}`);
+  }
+  if (typeof value !== 'string') {
+    throw new Error(`unexpected type of ${enumName}: "${typeof value}"`);
+  }
+  const casedValue = getEnumNames(enumVariable)
+    .find((enumValue) => enumValue.toLowerCase() === value.toLowerCase());
+  if (!casedValue) {
+    throw new Error(`unknown ${enumName}: "${value}"`);
+  }
+  return enumVariable[casedValue as keyof typeof enumVariable];
+}
+
+export function getEnumNames
+<T extends EnumType, TEnumValue extends EnumType>(
+  enumVariable: EnumVariable<T, TEnumValue>,
+): string[] {
+  return Object
+    .values(enumVariable)
+    .filter((enumMember) => typeof enumMember === 'string') as string[];
 }
 
 export function getEnumValues<T extends EnumType, TEnumValue extends EnumType>(
-    enumVariable: EnumVariable<T, TEnumValue>): TEnumValue[] {
-    return getEnumNames(enumVariable)
-        .map((level) => enumVariable[level]) as TEnumValue[];
+  enumVariable: EnumVariable<T, TEnumValue>,
+): TEnumValue[] {
+  return getEnumNames(enumVariable)
+    .map((level) => enumVariable[level]) as TEnumValue[];
 }
 
 export function assertInRange<T extends EnumType, TEnumValue extends EnumType>(
-    value: TEnumValue,
-    enumVariable: EnumVariable<T, TEnumValue>) {
-    if (value === undefined) {
-        throw new Error('undefined enum value');
-    }
-    if (!(value in enumVariable)) {
-        throw new RangeError(`enum value "${value}" is out of range`);
-    }
+  value: TEnumValue,
+  enumVariable: EnumVariable<T, TEnumValue>,
+) {
+  if (value === undefined) {
+    throw new Error('undefined enum value');
+  }
+  if (!(value in enumVariable)) {
+    throw new RangeError(`enum value "${value}" is out of range`);
+  }
 }

src/application/Common/ScriptingLanguage/IScriptingLanguageFactory.ts

@@ -1,5 +1,5 @@
 import { ScriptingLanguage } from '@/domain/ScriptingLanguage';
 
 export interface IScriptingLanguageFactory<T> {
-    create(language: ScriptingLanguage): T;
+  create(language: ScriptingLanguage): T;
 }

src/application/Common/ScriptingLanguage/ScriptingLanguageFactory.ts

@@ -1,31 +1,30 @@
 import { ScriptingLanguage } from '@/domain/ScriptingLanguage';
-import { IScriptingLanguageFactory } from './IScriptingLanguageFactory';
 import { assertInRange } from '@/application/Common/Enum';
+import { IScriptingLanguageFactory } from './IScriptingLanguageFactory';
 
 type Getter<T> = () => T;
 
 export abstract class ScriptingLanguageFactory<T> implements IScriptingLanguageFactory<T> {
-    private readonly getters = new Map<ScriptingLanguage, Getter<T>>();
+  private readonly getters = new Map<ScriptingLanguage, Getter<T>>();
 
-    public create(language: ScriptingLanguage): T {
-        assertInRange(language, ScriptingLanguage);
-        if (!this.getters.has(language)) {
-            throw new RangeError(`unknown language: "${ScriptingLanguage[language]}"`);
-        }
-        const getter = this.getters.get(language);
-        const instance = getter();
-        return instance;
+  public create(language: ScriptingLanguage): T {
+    assertInRange(language, ScriptingLanguage);
+    if (!this.getters.has(language)) {
+      throw new RangeError(`unknown language: "${ScriptingLanguage[language]}"`);
     }
+    const getter = this.getters.get(language);
+    const instance = getter();
+    return instance;
+  }
 
-    protected registerGetter(language: ScriptingLanguage, getter: Getter<T>) {
-        assertInRange(language, ScriptingLanguage);
-        if (!getter)  {
-            throw new Error('undefined getter');
-        }
-        if (this.getters.has(language)) {
-            throw new Error(`${ScriptingLanguage[language]} is already registered`);
-        }
-        this.getters.set(language, getter);
+  protected registerGetter(language: ScriptingLanguage, getter: Getter<T>) {
+    assertInRange(language, ScriptingLanguage);
+    if (!getter) {
+      throw new Error('undefined getter');
     }
-
+    if (this.getters.has(language)) {
+      throw new Error(`${ScriptingLanguage[language]} is already registered`);
+    }
+    this.getters.set(language, getter);
+  }
 }