From 52a4730073b8ebfb2ce9d530b44e4a179f5849fe Mon Sep 17 00:00:00 2001 From: undergroundwires Date: Fri, 10 May 2024 12:18:16 +0200 Subject: [PATCH] ci/cd: remove `check-latest` from `setup-node` This commit addresses the issue where Windows GitHub runners experience failures due to unstable Node.js releases, particularly version 20.13.0, as detailed in nodejs/node#52884 and nodejs/node#52682. The 'check-latest' input in the 'setup-node' GitHub Action forces every job to verify and potentially install the latest Node.js version. This input was originally introduced to reduce maintenance efforts to keep CI/CD setup up-to-date with the latest Node version. However, the necessity to always run the latest Node.js version is not critical for the CI/CD setup. Additionally, it causes increased network requests and may inadvertently introduce unstable Node.js versions. This commit removes the 'check-latest' option to prevent the immediate adoption of new, potentially unstable Node.js releases, thus simplifying the CI/CD pipeline. This keeps CI/CD process is robust and predictable, reducing the chances of unexpected disruptions in service deployment. --- .github/actions/setup-node/action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/actions/setup-node/action.yml b/.github/actions/setup-node/action.yml index 8b52ca6d..dc6d3c95 100644 --- a/.github/actions/setup-node/action.yml +++ b/.github/actions/setup-node/action.yml @@ -6,4 +6,4 @@ runs: uses: actions/setup-node@v4 with: node-version: 20.x - check-latest: true + # check-latest: true # Newest versions can potentially have undiscovered bugs or regressions