From 4531645b4c0c5143f15240652368bb9b9ddb48a4 Mon Sep 17 00:00:00 2001 From: undergroundwires Date: Fri, 17 Nov 2023 13:57:13 +0100 Subject: [PATCH] Refactor to Vue 3 recommended ESLint rules These updates ensure better adherence to Vue 3 standards and improve overall code quality and readability. - Update ESLint configuration from Vue 2.x to Vue 3 rules. - Switch from "essential" to strictest "recommended" ESLint ruleset. - Adjust ESLint script to treat warnings as errors by using `--max-warnings=0` flag. This enforces stricter code quality controls provided by Vue 3 rules. --- .eslintrc.cjs | 2 +- package-lock.json | 2 +- package.json | 2 +- src/presentation/components/App.vue | 5 +++- .../Code/CodeButtons/CodeCopyButton.vue | 2 +- .../Code/CodeButtons/CodeRunButton.vue | 2 +- .../Code/CodeButtons/IconButton.vue | 4 ++- .../Code/CodeButtons/Save/CodeSaveButton.vue | 2 +- .../Save/Instructions/CodeInstruction.vue | 2 +- .../Save/Instructions/InfoTooltip.vue | 2 +- .../Save/Instructions/InstructionList.vue | 10 ++++--- .../Code/CodeButtons/TheCodeButtons.vue | 2 +- .../components/Code/TheCodeArea.vue | 17 ++++++------ .../components/DevToolkit/DevToolkit.vue | 5 ++-- .../Scripts/Menu/MenuOptionList.vue | 4 ++- .../Scripts/Menu/MenuOptionListItem.vue | 7 ++--- .../Scripts/Menu/Selector/TheSelector.vue | 8 +++--- .../components/Scripts/Menu/TheOsChanger.vue | 2 +- .../Scripts/Menu/TheScriptsMenu.vue | 11 ++++++-- .../Scripts/Menu/View/TheViewChanger.vue | 3 ++- .../Scripts/Slider/HorizontalResizeSlider.vue | 4 +-- .../Scripts/Slider/SliderHandle.vue | 3 ++- .../components/Scripts/TheScriptArea.vue | 16 +++++------ .../Scripts/View/Cards/CardList.vue | 20 ++++++++------ .../Scripts/View/Cards/CardListItem.vue | 20 +++++++------- .../View/Cards/CardSelectionIndicator.vue | 4 +-- .../Scripts/View/TheScriptsView.vue | 5 ++-- .../Documentation/DocumentableNode.vue | 14 ++++++---- .../Documentation/DocumentationText.vue | 3 ++- .../ToggleDocumentationButton.vue | 6 ++--- .../View/Tree/NodeContent/NodeContent.vue | 9 ++++--- .../View/Tree/NodeContent/RevertToggle.vue | 2 +- .../View/Tree/NodeContent/ToggleSwitch.vue | 2 +- .../Scripts/View/Tree/ScriptsTree.vue | 20 +++++++------- .../TreeView/Node/HierarchicalTreeNode.vue | 19 ++++++------- .../View/Tree/TreeView/Node/LeafTreeNode.vue | 6 ++--- .../View/Tree/TreeView/TreeRoot/TreeRoot.vue | 8 +++--- .../Scripts/View/Tree/TreeView/TreeView.vue | 16 +++++------ .../components/Shared/Icon/AppIcon.vue | 21 ++++++++------- .../Shared/Modal/ModalContainer.vue | 16 +++++------ .../components/Shared/Modal/ModalDialog.vue | 10 +++---- .../components/Shared/TooltipWrapper.vue | 3 ++- .../components/TheFooter/DownloadUrlList.vue | 13 ++++++--- .../TheFooter/DownloadUrlListItem.vue | 5 ++-- .../components/TheFooter/PrivacyPolicy.vue | 27 ++++++++++++++----- src/presentation/components/TheHeader.vue | 8 ++++-- src/presentation/components/TheSearchBar.vue | 4 +-- .../Tree/NodeContent/ToggleSwitch.spec.ts | 16 +++++------ .../components/Shared/Icon/AppIcon.spec.ts | 1 + tests/unit/shared/Stubs/SizeObserverStub.ts | 2 +- 50 files changed, 231 insertions(+), 166 deletions(-) diff --git a/.eslintrc.cjs b/.eslintrc.cjs index 1a06a757..03c92972 100644 --- a/.eslintrc.cjs +++ b/.eslintrc.cjs @@ -10,7 +10,7 @@ module.exports = { }, extends: [ // Vue specific rules, eslint-plugin-vue - 'plugin:vue/essential', + 'plugin:vue/vue3-recommended', // Extends eslint-config-airbnb '@vue/eslint-config-airbnb-with-typescript', diff --git a/package-lock.json b/package-lock.json index 913ceea4..8597d6b6 100644 --- a/package-lock.json +++ b/package-lock.json @@ -6,7 +6,7 @@ "packages": { "": { "name": "privacy.sexy", - "version": "0.12.5", + "version": "0.12.7", "hasInstallScript": true, "dependencies": { "@floating-ui/vue": "^1.0.2", diff --git a/package.json b/package.json index b6b0d00c..a3b4a704 100644 --- a/package.json +++ b/package.json @@ -24,7 +24,7 @@ "electron:preview": "electron-vite preview", "electron:prebuild": "electron-vite build", "electron:build": "electron-builder", - "lint:eslint": "eslint . --ignore-path .gitignore", + "lint:eslint": "eslint . --max-warnings=0 --ignore-path .gitignore", "lint:md": "markdownlint **/*.md --ignore node_modules", "lint:md:consistency": "remark . --frail --use remark-preset-lint-consistent", "lint:md:relative-urls": "remark . --frail --use remark-validate-links", diff --git a/src/presentation/components/App.vue b/src/presentation/components/App.vue index d40f48cd..5371b458 100644 --- a/src/presentation/components/App.vue +++ b/src/presentation/components/App.vue @@ -7,7 +7,10 @@ - + diff --git a/src/presentation/components/Code/CodeButtons/CodeCopyButton.vue b/src/presentation/components/Code/CodeButtons/CodeCopyButton.vue index 3c38cdba..1da69814 100644 --- a/src/presentation/components/Code/CodeButtons/CodeCopyButton.vue +++ b/src/presentation/components/Code/CodeButtons/CodeCopyButton.vue @@ -1,8 +1,8 @@ diff --git a/src/presentation/components/Code/CodeButtons/CodeRunButton.vue b/src/presentation/components/Code/CodeButtons/CodeRunButton.vue index 9fef14cf..a3c579d8 100644 --- a/src/presentation/components/Code/CodeButtons/CodeRunButton.vue +++ b/src/presentation/components/Code/CodeButtons/CodeRunButton.vue @@ -2,8 +2,8 @@ diff --git a/src/presentation/components/Code/CodeButtons/IconButton.vue b/src/presentation/components/Code/CodeButtons/IconButton.vue index 49983ce0..a8a9cc93 100644 --- a/src/presentation/components/Code/CodeButtons/IconButton.vue +++ b/src/presentation/components/Code/CodeButtons/IconButton.vue @@ -9,7 +9,9 @@ class="button__icon" :icon="iconName" /> -
{{text}}
+
+ {{ text }} +
diff --git a/src/presentation/components/Code/CodeButtons/Save/CodeSaveButton.vue b/src/presentation/components/Code/CodeButtons/Save/CodeSaveButton.vue index 7679358e..586cb77c 100644 --- a/src/presentation/components/Code/CodeButtons/Save/CodeSaveButton.vue +++ b/src/presentation/components/Code/CodeButtons/Save/CodeSaveButton.vue @@ -2,8 +2,8 @@
diff --git a/src/presentation/components/Code/CodeButtons/Save/Instructions/CodeInstruction.vue b/src/presentation/components/Code/CodeButtons/Save/Instructions/CodeInstruction.vue index 2a11bdc2..54313fb1 100644 --- a/src/presentation/components/Code/CodeButtons/Save/Instructions/CodeInstruction.vue +++ b/src/presentation/components/Code/CodeButtons/Save/Instructions/CodeInstruction.vue @@ -9,7 +9,7 @@ class="copy-button" @click="copyCode" /> -