refactor extra code, duplicates, complexity
- refactor array equality check and add tests - remove OperatingSystem.Unknown causing extra logic, return undefined instead - refactor enum validation to share same logic - refactor scripting language factories to share same logic - refactor too many args in runCodeAsync - refactor ScriptCode constructor to reduce complexity - fix writing useless write to member object since another property write always override it
This commit is contained in:
@@ -9,7 +9,7 @@ interface IDesktopTestCase {
|
||||
export const DesktopOsTestCases: ReadonlyArray<IDesktopTestCase> = [
|
||||
{
|
||||
processPlatform: 'aix',
|
||||
expectedOs: OperatingSystem.Unknown,
|
||||
expectedOs: undefined,
|
||||
},
|
||||
{
|
||||
processPlatform: 'darwin',
|
||||
@@ -17,7 +17,7 @@ export const DesktopOsTestCases: ReadonlyArray<IDesktopTestCase> = [
|
||||
},
|
||||
{
|
||||
processPlatform: 'freebsd',
|
||||
expectedOs: OperatingSystem.Unknown,
|
||||
expectedOs: undefined,
|
||||
},
|
||||
{
|
||||
processPlatform: 'linux',
|
||||
@@ -25,11 +25,11 @@ export const DesktopOsTestCases: ReadonlyArray<IDesktopTestCase> = [
|
||||
},
|
||||
{
|
||||
processPlatform: 'openbsd',
|
||||
expectedOs: OperatingSystem.Unknown,
|
||||
expectedOs: undefined,
|
||||
},
|
||||
{
|
||||
processPlatform: 'sunos',
|
||||
expectedOs: OperatingSystem.Unknown,
|
||||
expectedOs: undefined,
|
||||
},
|
||||
{
|
||||
processPlatform: 'win32',
|
||||
|
||||
Reference in New Issue
Block a user