refactor extra code, duplicates, complexity
- refactor array equality check and add tests - remove OperatingSystem.Unknown causing extra logic, return undefined instead - refactor enum validation to share same logic - refactor scripting language factories to share same logic - refactor too many args in runCodeAsync - refactor ScriptCode constructor to reduce complexity - fix writing useless write to member object since another property write always override it
This commit is contained in:
@@ -4,13 +4,14 @@ import { BrowserOsDetector } from '@/application/Environment/BrowserOs/BrowserOs
|
||||
import { BrowserOsTestCases } from './BrowserOsTestCases';
|
||||
|
||||
describe('BrowserOsDetector', () => {
|
||||
it('unkown when user agent is undefined', () => {
|
||||
it('returns undefined when user agent is undefined', () => {
|
||||
// arrange
|
||||
const expected = undefined;
|
||||
const sut = new BrowserOsDetector();
|
||||
// act
|
||||
const actual = sut.detect(undefined);
|
||||
// assert
|
||||
expect(actual).to.equal(OperatingSystem.Unknown);
|
||||
expect(actual).to.equal(expected);
|
||||
});
|
||||
it('detects as expected', () => {
|
||||
for (const testCase of BrowserOsTestCases) {
|
||||
|
||||
Reference in New Issue
Block a user